Enable VariationsService on Android.

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 1437 matching lines @@
 #endif
 
   PreBrowserStart();
 
   // Instantiate the notification UI manager, as this triggers a perf timer
   // used to measure startup time. TODO(stevenjb): Figure out what is actually
   // triggering the timer and call that explicitly in the approprate place.
   // http://crbug.com/105065.
   browser_process_->notification_ui_manager();
 
-#if !defined(OS_ANDROID)
+#if defined(OS_ANDROID)
+  chrome_variations::VariationsService* variations_service =
+      browser_process_->variations_service();
+  if (variations_service)
+    variations_service->StartRepeatedVariationsSeedFetch();

[SteveT, 2013/04/18 15:24:53]

Could you explain why we chose to do the Android call to StartRepeated from
here?

[Alexei Svitkine (slow), 2013/04/18 15:35:24]

If you look down the #else codepath, that's where it's done for non-Android
platforms. Since the #else path does a lot of other things unrelared to the
VariationsService, I've just extracted the VariationsService bits to here.

+#else
   // Most general initialization is behind us, but opening a
   // tab and/or session restore and such is still to be done.
   base::TimeTicks browser_open_start = base::TimeTicks::Now();
 
   // We are in regular browser boot sequence. Open initial tabs and enter the
   // main message loop.
   int result_code;
 #if defined(OS_CHROMEOS)
   // On ChromeOS multiple profiles doesn't apply, and will break if we load
   // them this early as the cryptohome hasn't yet been mounted (which happens
@@ skipping 43 matching lines @@
     // StartRepeatedVariationsSeedFetch.
     if (parameters().ui_task == NULL) {
       // Request new variations seed information from server.
       chrome_variations::VariationsService* variations_service =
           browser_process_->variations_service();
       if (variations_service) {
         variations_service->StartRepeatedVariationsSeedFetch();
 
 #if defined(OS_WIN)
         variations_service->StartGoogleUpdateRegistrySync();
 #endif

[Nico, 2013/04/18 19:57:10]

nit: pull the body of the if into a StartVariations() function and call that
here and up in the #if android block

[Alexei Svitkine (slow), 2013/04/18 20:30:00]

I see the motivation for this, but I think the end result would be a little bit
confusing.

That's because this isn't the first call into the VariationsService - since
CreateTrialsFromSeed() gets called earlier during startup. So StartVariations()
wouldn't strictly be starting up the VariationsService, since it has already
been doing things prior to this.

So I think I prefer to keep the current way for now, which is explicit as to
what's actually being started.

       }
 
 #if !defined(OS_CHROMEOS)
       // TODO(mad): Move this call in a proper place on CrOS.
       // http://crosbug.com/17687
       if (translate_manager_ != NULL) {
         translate_manager_->FetchLanguageListFromTranslateServer(
             profile_->GetPrefs());
       }
 #endif
@@ skipping 201 matching lines @@
     if (base::win::GetVersion() <= base::win::VERSION_XP)
       uma_name += "_XP";
 
     uma_name += "_PreRead_";
     uma_name += pre_read_percentage;
     AddPreReadHistogramTime(uma_name.c_str(), time);
   }
 #endif
 #endif
 }