Source/bindings/v8/ScriptController.h - Issue 13954010: Eliminate "temporary" and "uninitialized" isolated worlds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.h

Issue 13954010: Eliminate "temporary" and "uninitialized" isolated worlds (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptController.h

diff --git a/Source/bindings/v8/ScriptController.h b/Source/bindings/v8/ScriptController.h

index 21104d2c1fe87f23fecbe677df96fd00d136f769..31742237ffe16ffe06fa692629baa4aa05ef5834 100644

--- a/Source/bindings/v8/ScriptController.h

+++ b/Source/bindings/v8/ScriptController.h

@@ -104,8 +104,6 @@ public:

// If an isolated world with the specified ID already exists, it is reused.

// Otherwise, a new world is created.

- // If the worldID is 0 or DOMWrapperWorld::uninitializedWorldId, a new world is always created.

- //

// FIXME: Get rid of extensionGroup here.

void evaluateInIsolatedWorld(int worldID, const Vector<ScriptSourceCode>& sources, int extensionGroup, Vector<ScriptValue>* results);