Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 13954002: Refactor IndexedDBInfo out of browsingdata (Closed)

Created:
7 years, 8 months ago by alecflett
Modified:
7 years, 8 months ago
Reviewers:
michaeln, jam, Jói, Evan Stade
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, markusheintz_
Visibility:
Public.

Description

Refactor IndexedDBInfo out of browsingdata The struct used for the "site content" UI is also going to be useful for chrome://indexeddb-internals, so I've factored that out so it can be reused. This patch doesn't reuse it, but it will be in a future patch. BUG=174188 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194063

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix performance_ui_tests too #

Total comments: 4

Patch Set 3 : Rebase to ToT #

Patch Set 4 : Fix cocoa build #

Patch Set 5 : Add in constructor for IndexedDBInfo #

Patch Set 6 : Add missing constructor implementation #

Patch Set 7 : Break out IndexedDBInfo #

Total comments: 1

Patch Set 8 : Fix extraneous includes #

Patch Set 9 : Add back file_path.h #

Patch Set 10 : Sigh. Forgot to lint. #

Patch Set 11 : Use CONTENT_EXPORT to avoid breaking the component build #

Patch Set 12 : Fix cocoa unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -80 lines) Patch
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.h View 5 chunks +6 lines, -21 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 2 3 4 5 6 7 8 9 5 chunks +12 lines, -24 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/local_data_container.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc View 1 2 3 4 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details_unittest.mm View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_cookie_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_cookie_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_context_impl.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +15 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/indexed_db_context.h View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -6 lines 0 comments Download
A content/public/browser/indexed_db_info.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +27 lines, -0 lines 0 comments Download
A content/public/browser/indexed_db_info.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
alecflett
joi - review for new function in content/public/browser? estade - review for gtk, and chrome/browser/ui/webui ...
7 years, 8 months ago (2013-04-09 23:06:39 UTC) #1
michaeln
lgtm https://codereview.chromium.org/13954002/diff/3001/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc File chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc (right): https://codereview.chromium.org/13954002/diff/3001/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc#newcode31 chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc:31: content::IndexedDBInfo info1 = { kOrigin1, 1, base::Time() }; ...
7 years, 8 months ago (2013-04-10 00:47:25 UTC) #2
michaeln
https://codereview.chromium.org/13954002/diff/1/chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc File chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc (right): https://codereview.chromium.org/13954002/diff/1/chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc#newcode110 chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc:110: const IndexedDBInfo& origin = *iter; nit: maybe change this ...
7 years, 8 months ago (2013-04-10 00:51:17 UTC) #3
Evan Stade
lgtm, feel free to TBR OWNERS reviews of this sort.
7 years, 8 months ago (2013-04-10 05:12:17 UTC) #4
Jói
LGTM for content/public
7 years, 8 months ago (2013-04-10 09:02:45 UTC) #5
alecflett
https://codereview.chromium.org/13954002/diff/3001/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc File chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc (right): https://codereview.chromium.org/13954002/diff/3001/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc#newcode31 chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc:31: content::IndexedDBInfo info1 = { kOrigin1, 1, base::Time() }; On ...
7 years, 8 months ago (2013-04-10 17:17:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/3001
7 years, 8 months ago (2013-04-10 17:17:39 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-10 17:53:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/24001
7 years, 8 months ago (2013-04-10 18:17:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/37001
7 years, 8 months ago (2013-04-10 21:10:15 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-10 21:12:29 UTC) #11
alecflett
So I had to fix the mac cocoa build and I ended up switching to ...
7 years, 8 months ago (2013-04-10 21:45:29 UTC) #12
jam
On 2013/04/10 21:45:29, alecflett wrote: > So I had to fix the mac cocoa build ...
7 years, 8 months ago (2013-04-11 02:18:54 UTC) #13
alecflett
On 2013/04/11 02:18:54, jam wrote: > per content api convention, each class/struct/enum should be in ...
7 years, 8 months ago (2013-04-11 17:53:17 UTC) #14
jam
looks like you're missing the new header https://codereview.chromium.org/13954002/diff/56001/content/public/browser/indexed_db_context.h File content/public/browser/indexed_db_context.h (right): https://codereview.chromium.org/13954002/diff/56001/content/public/browser/indexed_db_context.h#newcode11 content/public/browser/indexed_db_context.h:11: #include "base/files/file_path.h" ...
7 years, 8 months ago (2013-04-11 18:19:25 UTC) #15
alecflett
On 2013/04/11 18:19:25, jam wrote: > looks like you're missing the new header > > ...
7 years, 8 months ago (2013-04-11 18:49:32 UTC) #16
alecflett
jam@ - this is ready to go - I ended up putting base/files/file_path.h in there ...
7 years, 8 months ago (2013-04-11 22:17:14 UTC) #17
jam
lgtm
7 years, 8 months ago (2013-04-12 16:43:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/67001
7 years, 8 months ago (2013-04-12 17:23:48 UTC) #19
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-12 17:54:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/67001
7 years, 8 months ago (2013-04-12 17:58:52 UTC) #21
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-12 18:13:11 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/77003
7 years, 8 months ago (2013-04-12 21:18:34 UTC) #23
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-12 22:32:52 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/13954002/82001
7 years, 8 months ago (2013-04-12 22:32:59 UTC) #25
commit-bot: I haz the power
7 years, 8 months ago (2013-04-13 01:25:02 UTC) #26
Message was sent while issue was closed.
Change committed as 194063

Powered by Google App Engine
This is Rietveld 408576698