Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Issue 1395363005: Revert of Reenable AppleEventUtilTest.ValueToAppleEventDescriptor by removing the failing case. (Closed)

Created:
5 years, 2 months ago by benwells
Modified:
5 years, 2 months ago
Reviewers:
Avi (use Gerrit), Andre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reenable AppleEventUtilTest.ValueToAppleEventDescriptor by removing the failing case. (patchset #1 id:1 of https://codereview.chromium.org/1399383002/ ) Reason for revert: This caused failures on mac asan. See http://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/7109 Will put more info on the linked bug. The asan failure is hopefully a good clue to fix the underlying flakiness :) Original issue's description: > Reenable AppleEventUtilTest.ValueToAppleEventDescriptor by removing the failing case. > > BUG=239807 > TEST=AppleEventUtilTest.ValueToAppleEventDescriptor > > Committed: https://crrev.com/265ed5079f1b1d47b62d9698dd83ec2208a62a12 > Cr-Commit-Position: refs/heads/master@{#353845} TBR=andresantoso@chromium.org,avi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=239807 Committed: https://crrev.com/a92ca31b74cc15011b57b69a3d9f835639ef4ac4 Cr-Commit-Position: refs/heads/master@{#353890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
Created Revert of Reenable AppleEventUtilTest.ValueToAppleEventDescriptor by removing the failing case.
5 years, 2 months ago (2015-10-13 22:51:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395363005/1
5 years, 2 months ago (2015-10-13 22:53:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-13 22:59:00 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 23:00:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a92ca31b74cc15011b57b69a3d9f835639ef4ac4
Cr-Commit-Position: refs/heads/master@{#353890}

Powered by Google App Engine
This is Rietveld 408576698