fpdfsdk/src/fpdf_dataavail.cpp - Issue 1395353004: Merge to XFA: Introduce CPDFDocumentFromFPDFDocument().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_dataavail.cpp

Issue 1395353004: Merge to XFA: Introduce CPDFDocumentFromFPDFDocument(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Fix build. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_dataavail.cpp

diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp

index d3b44160a8104898b88eb1545a0107371ffd9925..1b8162a403a2b98e3d4ef0f43e60b8eff077f10c 100644

--- a/fpdfsdk/src/fpdf_dataavail.cpp

+++ b/fpdfsdk/src/fpdf_dataavail.cpp

@@ -119,9 +119,9 @@ FPDFAvail_GetDocument(FPDF_AVAIL avail, FPDF_BYTESTRING password) {

}

DLLEXPORT int STDCALL FPDFAvail_GetFirstPageNum(FPDF_DOCUMENT doc) {

- if (doc == NULL)

+ CPDF_Document* pDoc = CPDFDocumentFromFPDFDocument(doc);

+ if (!doc)

return 0;

- CPDF_Document* pDoc = ((CPDFXFA_Document*)doc)->GetPDFDoc();

return ((CPDF_Parser*)pDoc->GetParser())->GetFirstPageNo();

Lei Zhang 2015/10/15 22:44:26 BTW, this cast is pointless. I need some shades so

Tom Sepez 2015/10/15 23:18:09 Done. Also a subtle error where the !pDoc not !do

}