[swarming] Let v8 test driver use gtest environment variables for shards.

[swarming] Let v8 test driver use gtest environment variables for shards.

BUG=chromium:535160
LOG=n
NOTRY=true

Committed: https://crrev.com/35833b71391f7abb738f77aa5bac512fd1e7f67a
Cr-Commit-Position: refs/heads/master@{#31207}

[Michael Achenbach, 2015-10-12 11:22:18]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2015-10-12 11:25:26]

PTAL. The variable names seem to be hardcoded in swarming when shards are used.

Passing them on the command line doesn't work as they're not present when
arguments are evaluated in the shell, e.g. see:
https://chromium-swarm.appspot.com/user/task/2a745c9267beda10

[Michael Achenbach, 2015-10-12 11:25:32]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-12 11:25:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395343002/1

[commit-bot: I haz the power, 2015-10-12 11:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-12 11:47:36]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2015-10-12 11:54:31]

lgtm

https://codereview.chromium.org/1395343002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/1395343002/diff/1/tools/run-tests.py#newcode463
tools/run-tests.py:463: # If none is present, use values passed on the command
line.
since this overrides values specified on cmd, maybe spit a warning?

[Michael Achenbach, 2015-10-12 11:56:23]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-10-12 11:56:24]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2015-10-12 11:56:27]

The CQ bit was unchecked by machenbach@chromium.org

[Michael Achenbach, 2015-10-12 12:03:03]

https://codereview.chromium.org/1395343002/diff/1/tools/run-tests.py
File tools/run-tests.py (right):

https://codereview.chromium.org/1395343002/diff/1/tools/run-tests.py#newcode463
tools/run-tests.py:463: # If none is present, use values passed on the command
line.
On 2015/10/12 11:54:31, tandrii(chromium) wrote:
> since this overrides values specified on cmd, maybe spit a warning?

Done.

[Michael Achenbach, 2015-10-12 12:06:10]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2015-10-12 12:06:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1395343002/#ps20001
(title: "Log problems")

[commit-bot: I haz the power, 2015-10-12 12:06:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1395343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1395343002/20001

[commit-bot: I haz the power, 2015-10-12 12:08:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-12 12:09:28]

Patchset 2 (id:??) landed as
https://crrev.com/35833b71391f7abb738f77aa5bac512fd1e7f67a
Cr-Commit-Position: refs/heads/master@{#31207}

[Michael Achenbach, 2015-10-12 12:20:46]

Manually tested:
https://chromium-swarm.appspot.com/user/task/2a74ce5737b30610
https://chromium-swarm.appspot.com/user/task/2a74ce5d685e4f10