Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1395333004: dart2js cps_ir: Use JSNumber_methods where possible (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 2 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps_ir: Use JSNumber_methods where possible We can often use the JSNumber interceptor directly without choosing between JSNumber and JSInt. BUG= R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/52d7ad19781ad2a535027231aca2d954906cfc07

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +1 line, -1 line 2 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
Helps num.toInt(), num.round(), etc by eliminating getInterceptor calls for many common num operations. Brings MicroMath ...
5 years, 2 months ago (2015-10-14 01:16:02 UTC) #2
asgerf
LGTM https://codereview.chromium.org/1395333004/diff/1/pkg/compiler/lib/src/cps_ir/type_mask_system.dart File pkg/compiler/lib/src/cps_ir/type_mask_system.dart (right): https://codereview.chromium.org/1395333004/diff/1/pkg/compiler/lib/src/cps_ir/type_mask_system.dart#newcode215 pkg/compiler/lib/src/cps_ir/type_mask_system.dart:215: return t.nonNullable().containsOnlyInt(classWorld); On 2015/10/14 01:16:02, sra1 wrote: > ...
5 years, 2 months ago (2015-10-14 08:44:02 UTC) #3
sra1
5 years, 2 months ago (2015-10-14 19:57:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52d7ad19781ad2a535027231aca2d954906cfc07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698