Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1395333002: Change kerning & ligature tests (Closed)

Created:
5 years, 2 months ago by eae
Modified:
5 years, 2 months ago
Reviewers:
drott
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change kerning & ligature tests Change the font kerning and ligature tests to be pixel tests instead of ref-tests as the current references are built on the assumption that no font features are enabled for text by default. In many ways these tests do not currently test our kerning & ligature features instead they test the difference between the simple and complex paths. Changing these to be pixel tests allows the tests to correctly test the rendering of these font features. BUG=536784 R=drott@chromium.org Committed: https://crrev.com/80b1511e005db3babec3ed84c23afbfda2513ee2 Cr-Commit-Position: refs/heads/master@{#353492}

Patch Set 1 : #

Patch Set 2 : Patch for landing #

Messages

Total messages: 9 (4 generated)
eae
5 years, 2 months ago (2015-10-12 08:05:31 UTC) #2
drott
LGTM 😢
5 years, 2 months ago (2015-10-12 08:16:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395333002/40001
5 years, 2 months ago (2015-10-12 08:20:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-12 08:57:06 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 08:58:15 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80b1511e005db3babec3ed84c23afbfda2513ee2
Cr-Commit-Position: refs/heads/master@{#353492}

Powered by Google App Engine
This is Rietveld 408576698