Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1395273006: Enlarge default favicon to match its old dimensions. (Closed)

Created:
5 years, 2 months ago by Peter Kasting
Modified:
5 years, 2 months ago
Reviewers:
oshima, Evan Stade
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enlarge default favicon to match its old dimensions. This regressed in https://codereview.chromium.org/1304833003/ . This also updates the 32x32 and 64x64 favicons to match the 16x16 one. BUG=505953 TEST=Open about:blank, the favicon in the tab shouldn't look undersized TBR=oshima Committed: https://crrev.com/8b17c6f96ad2a4674be95d280221cfb38138435d Cr-Commit-Position: refs/heads/master@{#353926}

Patch Set 1 #

Patch Set 2 : Fix 64x64 2x size #

Messages

Total messages: 15 (6 generated)
Peter Kasting
5 years, 2 months ago (2015-10-13 21:44:08 UTC) #2
Evan Stade
lgtm
5 years, 2 months ago (2015-10-13 22:03:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395273006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395273006/1
5 years, 2 months ago (2015-10-13 22:13:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/109111)
5 years, 2 months ago (2015-10-13 22:52:46 UTC) #7
Peter Kasting
TBRing to oshima for OWNERS I compressed these at optimization level 2.
5 years, 2 months ago (2015-10-13 23:22:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395273006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395273006/20001
5 years, 2 months ago (2015-10-13 23:23:42 UTC) #12
oshima
lgtm
5 years, 2 months ago (2015-10-13 23:37:57 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 00:38:28 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-14 00:39:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b17c6f96ad2a4674be95d280221cfb38138435d
Cr-Commit-Position: refs/heads/master@{#353926}

Powered by Google App Engine
This is Rietveld 408576698