Issue 1395243002: Fix TODO comments; other nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1395243002: Fix TODO comments; other nits (Closed)

Created:
5 years, 2 months ago by srawlins

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix TODO comments; other nits Also s/Sets/Set/ and s/Returns/Return/ for consistency. BUG=https://github.com/dart-lang/sdk/issues/24541 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/bd8ba4b2ce82e109f321d4ccca1c4ffef7d21769

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -33 lines)			Patch
	M	pkg/analyzer/lib/src/generated/ast.dart	View		13 chunks	+13 lines, -33 lines	0 comments	Download

Total messages: 3 (1 generated)

srawlins

5 years, 2 months ago (2015-10-09 20:45:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd8ba4b2ce82e109f321d4ccca1c4ffef7d21769 (presubmit successful).