Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 13952005: Add tests for GlobalHandles::IterateObjectGroups. (Closed)

Created:
7 years, 8 months ago by marja
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Add tests for GlobalHandles::IterateObjectGroups. BUG=none TEST=cctest/test-global-handles Committed: http://code.google.com/p/v8/source/detail?r=14249

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : Code review (mstarzinger) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -0 lines) Patch
M src/global-handles.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-global-handles.cc View 1 2 1 chunk +311 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marja
ptal
7 years, 8 months ago (2013-04-11 08:42:23 UTC) #1
Michael Starzinger
Looking good, just a few nits. https://codereview.chromium.org/13952005/diff/2001/test/cctest/test-global-handles.cc File test/cctest/test-global-handles.cc (right): https://codereview.chromium.org/13952005/diff/2001/test/cctest/test-global-handles.cc#newcode1 test/cctest/test-global-handles.cc:1: // Copyright 2012 ...
7 years, 8 months ago (2013-04-12 09:12:32 UTC) #2
marja
thanks for having a look! https://codereview.chromium.org/13952005/diff/2001/test/cctest/test-global-handles.cc File test/cctest/test-global-handles.cc (right): https://codereview.chromium.org/13952005/diff/2001/test/cctest/test-global-handles.cc#newcode1 test/cctest/test-global-handles.cc:1: // Copyright 2012 the ...
7 years, 8 months ago (2013-04-12 09:33:04 UTC) #3
Michael Starzinger
LGTM. I'll land this.
7 years, 8 months ago (2013-04-12 09:39:34 UTC) #4
Michael Starzinger
7 years, 8 months ago (2013-04-12 09:55:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r14249 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698