Fixes BrowserViewHostedAppTest.Layout when using MD

chrome/browser/ui/views/frame/browser_view_layout.cc

Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index a8d1c71940db9671eecdc80bc6967ea6f9f824b6..0bd6e22374639dca0624354f37f31c619209cf86 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -223,13 +223,13 @@ gfx::Rect BrowserViewLayout::GetFindBarBoundingBox() const {
     // miniature immersive style tab strip is visible. Do not overlap the
     // find bar and the tab strip.
     find_bar_y = top_container_bounds.bottom();
-  } else if (ui::MaterialDesignController::IsModeMaterial()) {
-    find_bar_y = top_container_bounds.bottom() - 6;
   } else {
-    // Position the find bar 1 pixel above the bottom of the top container
-    // so that it occludes the border between the content area and the top
-    // container and looks connected to the top container.
-    find_bar_y = top_container_bounds.bottom() - 1;
+    // Position the find bar above the bottom of the top container so that it
+    // occludes the border between the content area and the top container. The
+    // find bar should look connected to the top container when material design
+    // is not enabled.
+    find_bar_y = top_container_bounds.bottom() -
+                 GetLayoutConstant(FIND_BAR_VERTICAL_OFFSET);

[Peter Kasting, 2015/10/09 22:15:06]

It seems like this is more an "overlap" value than an "offset"?  Maybe
"FIND_BAR_TOOLBAR_OVERLAP"?  (I realize "toolbar" is a little overly-specific,
but it's roughly accurate, and "TOP_CONTAINER" is too vague in
layout_constants.h.)

Then maybe the comment can just be "Overlap the find bar atop |top_container_|."

[varkha, 2015/10/13 14:51:13]

Done. I've left the part about connected look when MD is not enabled, that
seemed like an important detail for now that is not easily read from code.

   }
 
   // Grow the height of |bounding_box| by the height of any elements between