chrome/browser/ui/views/frame/browser_view_unittest.cc - Issue 1395193002: Fixes BrowserViewHostedAppTest.Layout when using MD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view_unittest.cc

Issue 1395193002: Fixes BrowserViewHostedAppTest.Layout when using MD (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes BrowserViewHostedAppTest.Layout when using MD Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/frame/browser_view_layout.cc ('K') | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | chrome/browser/ui/views/layout_constants.h » ('j') | chrome/browser/ui/views/layout_constants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view_unittest.cc

diff --git a/chrome/browser/ui/views/frame/browser_view_unittest.cc b/chrome/browser/ui/views/frame/browser_view_unittest.cc

index a693b05ce586c64528c709b745d4d9a05c1ffea2..762c39428b5765ae189cf8618d6685deb0cc5547 100644

--- a/chrome/browser/ui/views/frame/browser_view_unittest.cc

+++ b/chrome/browser/ui/views/frame/browser_view_unittest.cc

@@ -200,7 +200,8 @@ TEST_F(BrowserViewHostedAppTest, Layout) {

EXPECT_EQ(bottom_of_header, contents_container->y());

// The find bar should overlap the 1px header/web-contents separator at the

- // bottom of the header.

- EXPECT_EQ(browser_view()->frame()->GetTopInset() - 1,

+ // bottom of the header or be a few pixels higher still with Material Design.

tdanderson 2015/10/09 18:12:09 nit: I don't think changing the comment here is ne

varkha 2015/10/09 18:20:35 Done.

+ EXPECT_EQ(browser_view()->frame()->GetTopInset() -

+ GetLayoutConstant(FIND_BAR_VERTICAL_OFFSET),

browser_view()->GetFindBarBoundingBox().y());

}