chrome/browser/ui/views/frame/browser_view_unittest.cc - Issue 1395193002: Fixes BrowserViewHostedAppTest.Layout when using MD

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/browser_view_unittest.cc

Issue 1395193002: Fixes BrowserViewHostedAppTest.Layout when using MD (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes BrowserViewHostedAppTest.Layout when using MD Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/frame/browser_view_layout.cc ('K') | « chrome/browser/ui/views/frame/browser_view_layout.cc ('k') | chrome/browser/ui/views/layout_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/frame/browser_view.h"	5 #include "chrome/browser/ui/views/frame/browser_view.h"

6	6

7 #include "chrome/app/chrome_command_ids.h"	7 #include "chrome/app/chrome_command_ids.h"

8 #include "chrome/browser/ui/browser_commands.h"	8 #include "chrome/browser/ui/browser_commands.h"

9 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"	9 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"

10 #include "chrome/browser/ui/views/frame/browser_view_layout.h"	10 #include "chrome/browser/ui/views/frame/browser_view_layout.h"

(...skipping 183 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
194 // The position of the bottom of the header (the bar with the window	194 // The position of the bottom of the header (the bar with the window

195 // controls) in the coordinates of BrowserView.	195 // controls) in the coordinates of BrowserView.

196 int bottom_of_header = browser_view()->frame()->GetTopInset() -	196 int bottom_of_header = browser_view()->frame()->GetTopInset() -

197 header_offset.y();	197 header_offset.y();

198	198

199 // The web contents should be flush with the bottom of the header.	199 // The web contents should be flush with the bottom of the header.

200 EXPECT_EQ(bottom_of_header, contents_container->y());	200 EXPECT_EQ(bottom_of_header, contents_container->y());

201	201

202 // The find bar should overlap the 1px header/web-contents separator at the	202 // The find bar should overlap the 1px header/web-contents separator at the

203 // bottom of the header.	203 // bottom of the header.

204 EXPECT_EQ(browser_view()->frame()->GetTopInset() - 1,	204 EXPECT_EQ(browser_view()->frame()->GetTopInset() -

	205 GetLayoutConstant(FIND_BAR_VERTICAL_OFFSET),
	Peter Kasting 2015/10/09 22:15:06 I would probably avoid checking this exact value, I would probably avoid checking this exact value, and instead check that the find bar y is less than the frame top inset. varkha 2015/10/13 14:51:13 Done. Show quoted text On 2015/10/09 22:15:06, Peter Kasting wrote: > I would probably avoid checking this exact value, and instead check that the > find bar y is less than the frame top inset. Done.
205 browser_view()->GetFindBarBoundingBox().y());	206 browser_view()->GetFindBarBoundingBox().y());

206 }	207 }

OLD	NEW