Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: pkg/compiler/lib/src/deferred_load.dart

Issue 1395183004: dart2js: mark FunctionElements as dependencies always (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/compiler/dart2js/deferred_not_in_main_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/deferred_load.dart
diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart
index 937e620ef9a1c5d92aa6db17a7d585e3066992fc..b8effae5e3696847b79bfbebfec11b736d4a2e26 100644
--- a/pkg/compiler/lib/src/deferred_load.dart
+++ b/pkg/compiler/lib/src/deferred_load.dart
@@ -264,6 +264,8 @@ class DeferredLoadTask extends CompilerTask {
/// Recursively collects all the dependencies of [type].
void collectTypeDependencies(DartType type) {
+ // TODO(het): we would like to separate out types that are only needed for
+ // rti from types that are needed for their members.
sigurdm 2015/10/13 07:39:07 I think johnniwinther is working on this.
if (type is GenericType) {
type.typeArguments.forEach(collectTypeDependencies);
}
@@ -341,8 +343,7 @@ class DeferredLoadTask extends CompilerTask {
}
}
- if (element is FunctionElement &&
- compiler.resolverWorld.closurizedMembers.contains(element)) {
+ if (element is FunctionElement) {
collectTypeDependencies(element.type);
}
« no previous file with comments | « no previous file | tests/compiler/dart2js/deferred_not_in_main_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698