dart2js: mark FunctionElements as dependencies always

pkg/compiler/lib/src/deferred_load.dart

Index: pkg/compiler/lib/src/deferred_load.dart
diff --git a/pkg/compiler/lib/src/deferred_load.dart b/pkg/compiler/lib/src/deferred_load.dart
index 937e620ef9a1c5d92aa6db17a7d585e3066992fc..7ce74a03eca554e328f24932b00b596fc8a87ff3 100644
--- a/pkg/compiler/lib/src/deferred_load.dart
+++ b/pkg/compiler/lib/src/deferred_load.dart
@@ -341,8 +341,7 @@ class DeferredLoadTask extends CompilerTask {
       }
     }
 
-    if (element is FunctionElement &&
-        compiler.resolverWorld.closurizedMembers.contains(element)) {

[Siggi Cherem (dart-lang), 2015/10/12 22:53:28]

mmm - would this pull in more than needed? Seems like in your test case though,
we were including B, but we were missing A, right? In that case, could it be
that the function dependency (foo -> B) is correct, but we are missing is the
dependency from a type to its super class (B -> A)?

[Harry Terkelsen, 2015/10/13 17:27:34]

The class to superclass dependency is handled here:
https://github.com/dart-lang/sdk/blob/master/pkg/compiler/lib/src/deferred_lo...

[Siggi Cherem (dart-lang), 2015/10/13 20:16:29]

Thanks for the pointer. Sorry for the confusion - I was seeing something
strange, the out.js file before your fix included foo and B's declaration, but
it appears that B was added later and not here, which would explain that we
weren't treating B as an actual dependency and adding A as well.

+    if (element is FunctionElement) {
       collectTypeDependencies(element.type);
     }