Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395153002: [iOS] Cleanup build/ios/grit_whitelist.txt. (Closed)

Created:
5 years, 2 months ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Cleanup build/ios/grit_whitelist.txt. Remove from build/ios/grit_whitelist.txt all resources that are not needed. Synchronize with downstream version of the file. BUG=None Committed: https://crrev.com/a8b75a6d21f35fc1b99578036114a998b50fc760 Cr-Commit-Position: refs/heads/master@{#357542}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Sync with downstream CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -99 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 6 chunks +6 lines, -99 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sdefresne
Please take a look.
5 years, 2 months ago (2015-10-09 16:31:58 UTC) #2
droger
lgtm
5 years, 2 months ago (2015-10-09 16:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395153002/20001
5 years, 2 months ago (2015-10-09 16:40:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/121617)
5 years, 2 months ago (2015-10-09 16:54:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395153002/40001
5 years, 1 month ago (2015-11-03 09:38:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-03 10:04:11 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 10:05:22 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a8b75a6d21f35fc1b99578036114a998b50fc760
Cr-Commit-Position: refs/heads/master@{#357542}

Powered by Google App Engine
This is Rietveld 408576698