Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/net/websocket_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
diff --git a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
index a1b1c0435f0c14afd33893a8b4a7caee7b3ab35c..445f9dfda01b0bae70d2fe4ff805f3a86ae1f829 100644
--- a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
+++ b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
@@ -78,14 +78,14 @@ class FFDecryptorServerChannelListener : public IPC::Listener {
DCHECK(!got_result);
result_bool = result;
got_result = true;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
void OnDecryptedTextResponse(const base::string16& decrypted_text) {
DCHECK(!got_result);
result_string = decrypted_text;
got_result = true;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
void OnParseSignonsResponse(
@@ -93,7 +93,7 @@ class FFDecryptorServerChannelListener : public IPC::Listener {
DCHECK(!got_result);
result_vector = parsed_vector;
got_result = true;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
void QuitClient() {
@@ -115,7 +115,7 @@ class FFDecryptorServerChannelListener : public IPC::Listener {
// If an error occured, just kill the message Loop.
void OnChannelError() override {
got_result = false;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// Results of IPC calls.
@@ -164,7 +164,7 @@ class CancellableQuitMsgLoop : public base::RefCounted<CancellableQuitMsgLoop> {
CancellableQuitMsgLoop() : cancelled_(false) {}
void QuitNow() {
if (!cancelled_)
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
bool cancelled_;
@@ -256,9 +256,7 @@ class FFDecryptorClientChannelListener : public IPC::Listener {
sender_->Send(new Msg_ParseSignons_Response(forms));
}
- void OnQuitRequest() {
- base::MessageLoop::current()->Quit();
- }
+ void OnQuitRequest() { base::MessageLoop::current()->QuitWhenIdle(); }
bool OnMessageReceived(const IPC::Message& msg) override {
bool handled = true;
@@ -272,7 +270,9 @@ class FFDecryptorClientChannelListener : public IPC::Listener {
return handled;
}
- void OnChannelError() override { base::MessageLoop::current()->Quit(); }
+ void OnChannelError() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
private:
NSSDecryptor decryptor_;
« no previous file with comments | « chrome/test/chromedriver/net/websocket_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698