chrome/common/worker_thread_ticker_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/worker_thread_ticker_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/service_process_util_unittest.cc ('k') | chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/worker_thread_ticker_unittest.cc

diff --git a/chrome/common/worker_thread_ticker_unittest.cc b/chrome/common/worker_thread_ticker_unittest.cc

index dbb2e01180299d50aaacd7953c7fd2fa2daafc88..57220308ed8c7bd76249429d8a8e4e165f13e6e5 100644

--- a/chrome/common/worker_thread_ticker_unittest.cc

+++ b/chrome/common/worker_thread_ticker_unittest.cc

@@ -21,8 +21,8 @@ class TestCallback : public WorkerThreadTicker::Callback {

counter_++;

// Finish the test faster.

- message_loop_->task_runner()->PostTask(FROM_HERE,

- base::MessageLoop::QuitClosure());

+ message_loop_->task_runner()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

}

int counter() const { return counter_; }

@@ -41,7 +41,7 @@ class LongCallback : public WorkerThreadTicker::Callback {

void RunMessageLoopForAWhile() {

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(500));

base::MessageLoop::current()->Run();

}