chrome/browser/ui/views/keyboard_access_browsertest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/keyboard_access_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/keyboard_access_browsertest.cc

diff --git a/chrome/browser/ui/views/keyboard_access_browsertest.cc b/chrome/browser/ui/views/keyboard_access_browsertest.cc

index eaa5b47272ea519e748cab554e0f939e80b39227..deb8050e36f6bb4327c374a81db874c41cbf38b3 100644

--- a/chrome/browser/ui/views/keyboard_access_browsertest.cc

+++ b/chrome/browser/ui/views/keyboard_access_browsertest.cc

@@ -68,8 +68,8 @@ class ViewFocusChangeWaiter : public views::FocusChangeListener {

void OnDidChangeFocus(views::View* focused_before,

views::View* focused_now) override {

if (focused_now && focused_now->id() != previous_view_id_) {

- base::MessageLoop::current()->PostTask(FROM_HERE,

- base::MessageLoop::QuitClosure());

+ base::MessageLoop::current()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

}

@@ -113,8 +113,7 @@ class SendKeysMenuListener : public views::MenuListener {

} else {

SendKeyPress(browser_, ui::VKEY_ESCAPE);

base::MessageLoop::current()->PostDelayedTask(

- FROM_HERE,

- base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(200));

}