chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm ('k') | chrome/browser/ui/find_bar/find_bar_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

diff --git a/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc b/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

index d0e6b8c8c79cb33e5c668fc17969f40efab5ec71..7c987e18aea79767c530fd2f10a64525147bbb73 100644

--- a/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

+++ b/chrome/browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc

@@ -37,7 +37,7 @@ bool RunLoopUntil(const base::Callback<bool()>& condition) {

}

base::MessageLoop::current()->task_runner()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(20));

content::RunMessageLoop();

}

@@ -228,13 +228,11 @@ class FlashFullscreenInteractiveBrowserTest : public OutOfProcessPPAPITest {

// |expected_color|.

bool is_expected_color = false;

flash_fs_host->CopyFromBackingStore(

- gfx::Rect(0, 0, 1, 1),

- gfx::Size(1, 1),

+ gfx::Rect(0, 0, 1, 1), gfx::Size(1, 1),

base::Bind(

&FlashFullscreenInteractiveBrowserTest::CheckBitmapForFillColor,

- expected_color,

- &is_expected_color,

- base::MessageLoop::QuitClosure()),

+ expected_color, &is_expected_color,

+ base::MessageLoop::QuitWhenIdleClosure()),

kN32_SkColorType);

content::RunMessageLoop();