chrome/browser/sync/test/integration/bookmarks_helper.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/bookmarks_helper.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/test/integration/bookmarks_helper.cc

diff --git a/chrome/browser/sync/test/integration/bookmarks_helper.cc b/chrome/browser/sync/test/integration/bookmarks_helper.cc

index aa9aba71fa317da3314f215f2d17d076435cffd6..4b5db5cc4106ba5f4abb1306dc379e01141a150b 100644

--- a/chrome/browser/sync/test/integration/bookmarks_helper.cc

+++ b/chrome/browser/sync/test/integration/bookmarks_helper.cc

@@ -129,7 +129,7 @@ class FaviconChangeObserver : public bookmarks::BookmarkModelObserver {

const BookmarkNode* node) override {

if (model == model_ && node == node_) {

if (!wait_for_load_ || (wait_for_load_ && node->is_favicon_loaded()))

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

}

« no previous file with comments | « chrome/browser/sync/profile_sync_test_util.h ('k') | chrome/browser/sync/test/integration/passwords_helper.cc » ('j') | no next file with comments »