chrome/browser/ssl/ssl_browser_tests.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc ('k') | chrome/browser/sync/glue/browser_thread_model_worker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_browser_tests.cc

diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc

index 8b79012978c0ed3cd60fff358e462591e524929d..cd4a1774e47c211a4deb61faa1d8896e2053defa 100644

--- a/chrome/browser/ssl/ssl_browser_tests.cc

+++ b/chrome/browser/ssl/ssl_browser_tests.cc

@@ -125,7 +125,7 @@ class ProvisionalLoadWaiter : public content::WebContentsObserver {

bool was_ignored_by_handler) override {

seen_ = true;

if (waiting_)

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

}

private:

@@ -336,7 +336,7 @@ class SSLUITest

// Wait a bit.

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromMilliseconds(kTimeoutMS));

content::RunMessageLoop();

}

@@ -1760,7 +1760,7 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, DISABLED_TestCloseTabWithUnsafePopup) {

if (IsShowingWebContentsModalDialog())

break;

base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(

- FROM_HERE, base::MessageLoop::QuitClosure(),

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure(),

base::TimeDelta::FromSeconds(1));

content::RunMessageLoop();

}