chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

index e98c15dbb0918dbbdbb9717e1f14b8ab47e326e4..5a98689e3edc58f894cd2afce304e86f9ceb79a3 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc

@@ -876,9 +876,7 @@ class TestSBClient

base::Bind(&TestSBClient::CheckDone, this));

}

- void CheckDone() {

- base::MessageLoopForUI::current()->Quit();

- }

+ void CheckDone() { base::MessageLoopForUI::current()->QuitWhenIdle(); }

SBThreatType threat_type_;

SafeBrowsingService* safe_browsing_service_;

@@ -1149,7 +1147,7 @@ class SafeBrowsingServiceShutdownTest : public SafeBrowsingServiceTest {

Profile::CreateStatus status) {

if (status == Profile::CREATE_STATUS_INITIALIZED) {

profile2_ = profile;

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}