chrome/browser/printing/printing_layout_browsertest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/printing_layout_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_view_manager_base.cc ('k') | chrome/browser/profiles/profile_list_desktop_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/printing_layout_browsertest.cc

diff --git a/chrome/browser/printing/printing_layout_browsertest.cc b/chrome/browser/printing/printing_layout_browsertest.cc

index 4755a18a00755499607662a581d2fce834187c57..3ab5dff019e3a0498589b8e3f51fdc2066a29e3c 100644

--- a/chrome/browser/printing/printing_layout_browsertest.cc

+++ b/chrome/browser/printing/printing_layout_browsertest.cc

@@ -80,7 +80,7 @@ class PrintingLayoutTest : public PrintingTest<InProcessBrowserTest>,

case printing::JobEventDetails::JOB_DONE: {

// Succeeded.

base::MessageLoop::current()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

break;

}

case printing::JobEventDetails::USER_INIT_CANCELED:

@@ -88,7 +88,7 @@ class PrintingLayoutTest : public PrintingTest<InProcessBrowserTest>,

// Failed.

ASSERT_TRUE(false);

base::MessageLoop::current()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

break;

}

case printing::JobEventDetails::NEW_DOC:

« no previous file with comments | « chrome/browser/printing/print_view_manager_base.cc ('k') | chrome/browser/profiles/profile_list_desktop_browsertest.cc » ('j') | no next file with comments »