Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index d965602107effc7e237589e92a5a146e109e1e89..d4b38f3d3038fe181285ec4aa7fd82f585b53c7e 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -295,17 +295,15 @@ class MakeRequestFail {
public:
// Sets up the filter on IO thread such that requests to |host| fail.
explicit MakeRequestFail(const std::string& host) : host_(host) {
- BrowserThread::PostTaskAndReply(
- BrowserThread::IO, FROM_HERE,
- base::Bind(MakeRequestFailOnIO, host_),
- base::MessageLoop::QuitClosure());
+ BrowserThread::PostTaskAndReply(BrowserThread::IO, FROM_HERE,
+ base::Bind(MakeRequestFailOnIO, host_),
+ base::MessageLoop::QuitWhenIdleClosure());
content::RunMessageLoop();
}
~MakeRequestFail() {
- BrowserThread::PostTaskAndReply(
- BrowserThread::IO, FROM_HERE,
- base::Bind(UndoMakeRequestFailOnIO, host_),
- base::MessageLoop::QuitClosure());
+ BrowserThread::PostTaskAndReply(BrowserThread::IO, FROM_HERE,
+ base::Bind(UndoMakeRequestFailOnIO, host_),
+ base::MessageLoop::QuitWhenIdleClosure());
content::RunMessageLoop();
}
@@ -688,10 +686,9 @@ class PolicyTest : public InProcessBrowserTest {
void OnScreenshotCompleted(
ScreenshotGrabberObserver::Result screenshot_result,
const base::FilePath& screenshot_path) override {
- BrowserThread::PostTaskAndReply(BrowserThread::IO,
- FROM_HERE,
+ BrowserThread::PostTaskAndReply(BrowserThread::IO, FROM_HERE,
base::Bind(base::DoNothing),
- base::MessageLoop::QuitClosure());
+ base::MessageLoop::QuitWhenIdleClosure());
}
~QuitMessageLoopAfterScreenshot() override {}

Powered by Google App Engine
This is Rietveld 408576698