chrome/browser/password_manager/password_store_win_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_win_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_proxy_mac_unittest.cc ('k') | chrome/browser/policy/cloud/device_management_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_win_unittest.cc

diff --git a/chrome/browser/password_manager/password_store_win_unittest.cc b/chrome/browser/password_manager/password_store_win_unittest.cc

index c1c7ecba434f823528ac96d62b6d51cf25de79ac..173fe165ee51b35520da529d4e499b07f80e5c4b 100644

--- a/chrome/browser/password_manager/password_store_win_unittest.cc

+++ b/chrome/browser/password_manager/password_store_win_unittest.cc

@@ -146,8 +146,8 @@ class PasswordStoreWinTest : public testing::Test {

BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,

base::Bind(&base::WaitableEvent::Signal, base::Unretained(&done)));

done.Wait();

- base::MessageLoop::current()->PostTask(FROM_HERE,

- base::MessageLoop::QuitClosure());

+ base::MessageLoop::current()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

base::MessageLoop::current()->Run();

db_thread_.Stop();

}

@@ -182,7 +182,7 @@ ACTION(STLDeleteElements0) {

ACTION(QuitUIMessageLoop) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

MATCHER(EmptyWDResult, "") {