chrome/browser/password_manager/native_backend_gnome_x_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/sdch_browsertest.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

index adcd284cfe26bd86173559b05d90c408a70cb7dd..c387919e60827a72f6ccbf7376bdc2ca913af3c4 100644

--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

@@ -405,7 +405,7 @@ class NativeBackendGnomeTest : public testing::Test {

void TearDown() override {

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

base::MessageLoop::current()->Run();

db_thread_.Stop();

}

@@ -422,7 +422,8 @@ class NativeBackendGnomeTest : public testing::Test {

}

static void PostQuitTask(base::MessageLoop* loop) {

- loop->task_runner()->PostTask(FROM_HERE, base::MessageLoop::QuitClosure());

+ loop->task_runner()->PostTask(FROM_HERE,

+ base::MessageLoop::QuitWhenIdleClosure());

}

void CheckUint32Attribute(const MockKeyringItem* item,

« no previous file with comments | « chrome/browser/net/sdch_browsertest.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc » ('j') | no next file with comments »