Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: chrome/browser/metrics/thread_watcher_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/thread_watcher_unittest.cc
diff --git a/chrome/browser/metrics/thread_watcher_unittest.cc b/chrome/browser/metrics/thread_watcher_unittest.cc
index 43c6b5c6657d5ab1fb32ea63d2b0796c0ff3b346..ea47fa3e843855ff689fbaacfb8c68725cf07557 100644
--- a/chrome/browser/metrics/thread_watcher_unittest.cc
+++ b/chrome/browser/metrics/thread_watcher_unittest.cc
@@ -701,7 +701,7 @@ TEST_F(ThreadWatcherListTest, Restart) {
ThreadWatcherList::StartWatchingAll(*base::CommandLine::ForCurrentProcess());
ThreadWatcherList::StopWatchingAll();
message_loop_for_ui.task_runner()->PostDelayedTask(
- FROM_HERE, message_loop_for_ui.QuitClosure(),
+ FROM_HERE, message_loop_for_ui.QuitWhenIdleClosure(),
base::TimeDelta::FromSeconds(
ThreadWatcherList::g_initialize_delay_seconds));
message_loop_for_ui.Run();
@@ -713,7 +713,7 @@ TEST_F(ThreadWatcherListTest, Restart) {
// Proceed with just |StartWatchingAll| and ensure it'll be started.
ThreadWatcherList::StartWatchingAll(*base::CommandLine::ForCurrentProcess());
message_loop_for_ui.task_runner()->PostDelayedTask(
- FROM_HERE, message_loop_for_ui.QuitClosure(),
+ FROM_HERE, message_loop_for_ui.QuitWhenIdleClosure(),
base::TimeDelta::FromSeconds(
ThreadWatcherList::g_initialize_delay_seconds + 1));
message_loop_for_ui.Run();
@@ -725,7 +725,7 @@ TEST_F(ThreadWatcherListTest, Restart) {
// Finally, StopWatchingAll() must stop.
ThreadWatcherList::StopWatchingAll();
message_loop_for_ui.task_runner()->PostDelayedTask(
- FROM_HERE, message_loop_for_ui.QuitClosure(),
+ FROM_HERE, message_loop_for_ui.QuitWhenIdleClosure(),
base::TimeDelta::FromSeconds(
ThreadWatcherList::g_initialize_delay_seconds));
message_loop_for_ui.Run();
« no previous file with comments | « chrome/browser/metrics/metrics_memory_details_browsertest.cc ('k') | chrome/browser/net/dns_probe_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698