Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: chrome/browser/history/android/sqlite_cursor_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/android/sqlite_cursor.h ('k') | chrome/browser/history/history_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/android/sqlite_cursor_unittest.cc
diff --git a/chrome/browser/history/android/sqlite_cursor_unittest.cc b/chrome/browser/history/android/sqlite_cursor_unittest.cc
index 858f5e4c3362de0b66c4e4c9eca3989048c88eca..63b4d8ad9236dd2ff7980906e6301eaf0024162c 100644
--- a/chrome/browser/history/android/sqlite_cursor_unittest.cc
+++ b/chrome/browser/history/android/sqlite_cursor_unittest.cc
@@ -80,11 +80,15 @@ class SQLiteCursorTest : public testing::Test,
// Override SQLiteCursor::TestObserver.
void OnPostMoveToTask() override { base::MessageLoop::current()->Run(); }
- void OnGetMoveToResult() override { base::MessageLoop::current()->Quit(); }
+ void OnGetMoveToResult() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
void OnPostGetFaviconTask() override { base::MessageLoop::current()->Run(); }
- void OnGetFaviconResult() override { base::MessageLoop::current()->Quit(); }
+ void OnGetFaviconResult() override {
+ base::MessageLoop::current()->QuitWhenIdle();
+ }
protected:
TestingProfileManager profile_manager_;
@@ -117,13 +121,13 @@ class CallbackHelper : public base::RefCountedThreadSafe<CallbackHelper> {
void OnInserted(int64 id) {
success_ = id != 0;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
void OnQueryResult(AndroidStatement* statement) {
success_ = statement != NULL;
statement_ = statement;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
private:
« no previous file with comments | « chrome/browser/history/android/sqlite_cursor.h ('k') | chrome/browser/history/history_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698