chrome/browser/extensions/extension_user_script_loader_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_user_script_loader_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_storage_monitor_browsertest.cc ('k') | chrome/browser/extensions/permissions_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_user_script_loader_unittest.cc

diff --git a/chrome/browser/extensions/extension_user_script_loader_unittest.cc b/chrome/browser/extensions/extension_user_script_loader_unittest.cc

index 02de7812a67e8913288b35d86327c8a7de17c1cf..b343026777c56f451ac2414c239d8a7fb159118b 100644

--- a/chrome/browser/extensions/extension_user_script_loader_unittest.cc

+++ b/chrome/browser/extensions/extension_user_script_loader_unittest.cc

@@ -71,7 +71,7 @@ class ExtensionUserScriptLoaderTest : public testing::Test,

shared_memory_ = content::Details<base::SharedMemory>(details).ptr();

if (base::MessageLoop::current() == &message_loop_)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

// Directory containing user scripts.

@@ -97,8 +97,8 @@ TEST_F(ExtensionUserScriptLoaderTest, NoScripts) {

HostID(),

true /* listen_for_extension_system_loaded */);

loader.StartLoad();

- message_loop_.task_runner()->PostTask(FROM_HERE,

- base::MessageLoop::QuitClosure());

+ message_loop_.task_runner()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

message_loop_.Run();

ASSERT_TRUE(shared_memory_ != NULL);