Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 7935705c47df3f364887fccb08cf0bd7fcfd7bd2..d22415f5b26632a8642e154cc987749f5f9fddbe 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -1240,7 +1240,7 @@ void PackExtensionTestClient::OnPackSuccess(
// on with the rest of the test.
// This call to |Quit()| matches the call to |Run()| in the
// |PackPunctuatedExtension| test.
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
EXPECT_EQ(expected_crx_path_.value(), crx_path.value());
EXPECT_EQ(expected_private_key_path_.value(), private_key_path.value());
ASSERT_TRUE(base::PathExists(private_key_path));
@@ -4715,15 +4715,15 @@ class ExtensionCookieCallback {
void SetCookieCallback(bool result) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(&base::MessageLoop::Quit, weak_factory_.GetWeakPtr()));
+ FROM_HERE, base::Bind(&base::MessageLoop::QuitWhenIdle,
+ weak_factory_.GetWeakPtr()));
result_ = result;
}
void GetAllCookiesCallback(const net::CookieList& list) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(&base::MessageLoop::Quit, weak_factory_.GetWeakPtr()));
+ FROM_HERE, base::Bind(&base::MessageLoop::QuitWhenIdle,
+ weak_factory_.GetWeakPtr()));
list_ = list;
}
net::CookieList list_;

Powered by Google App Engine
This is Rietveld 408576698