chrome/browser/extensions/app_data_migrator_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_data_migrator_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc ('k') | chrome/browser/extensions/crx_installer_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_data_migrator_unittest.cc

diff --git a/chrome/browser/extensions/app_data_migrator_unittest.cc b/chrome/browser/extensions/app_data_migrator_unittest.cc

index 8bb4f43de1bbf2445710ebb919155eacea2b6d76..a9d1e32f3bb53a431603cc56d1059ca647e6c7b3 100644

--- a/chrome/browser/extensions/app_data_migrator_unittest.cc

+++ b/chrome/browser/extensions/app_data_migrator_unittest.cc

@@ -105,7 +105,7 @@ void MigrationCallback() {

}

void DidWrite(base::File::Error status, int64 bytes, bool complete) {

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void DidCreate(base::File::Error status) {

@@ -183,7 +183,7 @@ void VerifyFileContents(base::File file,

file.Close();

if (!on_close_callback.is_null())

on_close_callback.Run();

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void VerifyTestFilesMigrated(content::StoragePartition* new_partition,