chrome/browser/extensions/api/tabs/tabs_test.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_test.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc ('k') | chrome/browser/extensions/api/top_sites/top_sites_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_test.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_test.cc b/chrome/browser/extensions/api/tabs/tabs_test.cc

index 43cd585052945e121495535e2cad9a138c12ec1b..06e5571076024672eaa595f89691d53ca04ab77f 100644

--- a/chrome/browser/extensions/api/tabs/tabs_test.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_test.cc

@@ -832,7 +832,7 @@ class ExtensionWindowLastFocusedTest : public ExtensionTabsTest {

// AppWindowRegistry::Observer:

void OnAppWindowActivated(AppWindow* app_window) override {

if (app_window_ == app_window && waiting_) {

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

waiting_ = false;

}

@@ -864,7 +864,7 @@ class ExtensionWindowLastFocusedTest : public ExtensionTabsTest {

void OnWidgetActivationChanged(views::Widget* widget,

bool active) override {

if (widget_ == widget && waiting_) {

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

waiting_ = false;

}