chrome/browser/extensions/activity_log/activity_log_browsertest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/extensions/activity_log/counting_policy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log_browsertest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc

index 41fb70802a8972a4c77cf119aa675c79e885a81c..7cfd7c0c090ecf90b32d15211db2b54945a64ee4 100644

--- a/chrome/browser/extensions/activity_log/activity_log_browsertest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_browsertest.cc

@@ -42,7 +42,7 @@ class ActivityLogPrerenderTest : public ExtensionApiTest {

scoped_ptr<std::vector<scoped_refptr<Action> > > i) {

// This is to exit RunLoop (base::MessageLoop::current()->Run()) below

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

ASSERT_TRUE(i->size());

scoped_refptr<Action> last = i->front();