Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index e8fc89c1a1fe1f95bb844b58132934314e4c3bc0..b547a009f6ca69675e32a23e9c1ccee995c7981c 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -316,7 +316,7 @@ class DevToolsUnresponsiveBeforeUnloadTest: public DevToolsBeforeUnloadTest {
void TimeoutCallback(const std::string& timeout_message) {
ADD_FAILURE() << timeout_message;
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
}
// Base class for DevTools tests that test devtools functionality for
@@ -400,7 +400,7 @@ class DevToolsExtensionTest : public DevToolsSanityTest,
switch (type) {
case extensions::NOTIFICATION_EXTENSION_LOADED_DEPRECATED:
case extensions::NOTIFICATION_EXTENSION_HOST_DID_STOP_FIRST_LOAD:
- base::MessageLoopForUI::current()->Quit();
+ base::MessageLoopForUI::current()->QuitWhenIdle();
break;
default:
NOTREACHED();
@@ -454,7 +454,7 @@ class WorkerDevToolsSanityTest : public InProcessBrowserTest {
worker_data_->worker_route_id = route_id;
WorkerService::GetInstance()->RemoveObserver(this);
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
- base::MessageLoop::QuitClosure());
+ base::MessageLoop::QuitWhenIdleClosure());
delete this;
}
std::string path_;
@@ -475,7 +475,7 @@ class WorkerDevToolsSanityTest : public InProcessBrowserTest {
ASSERT_EQ(worker_data_->worker_route_id, route_id);
WorkerService::GetInstance()->RemoveObserver(this);
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
- base::MessageLoop::QuitClosure());
+ base::MessageLoop::QuitWhenIdleClosure());
delete this;
}
scoped_refptr<WorkerData> worker_data_;
@@ -521,7 +521,7 @@ class WorkerDevToolsSanityTest : public InProcessBrowserTest {
worker_data->worker_process_id = worker_info[0].process_id;
worker_data->worker_route_id = worker_info[0].route_id;
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
- base::MessageLoop::QuitClosure());
+ base::MessageLoop::QuitWhenIdleClosure());
return;
}
« no previous file with comments | « chrome/browser/devtools/device/usb/android_usb_browsertest.cc ('k') | chrome/browser/download/download_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698