chrome/browser/devtools/device/adb/mock_adb_server.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/adb/mock_adb_server.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/adb/adb_client_socket_browsertest.cc ('k') | chrome/browser/devtools/device/port_forwarding_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/adb/mock_adb_server.cc

diff --git a/chrome/browser/devtools/device/adb/mock_adb_server.cc b/chrome/browser/devtools/device/adb/mock_adb_server.cc

index 70e9a0cf9c0f8527e3b5e41e59cdfb0df3416e43..3fe93df82d1ceb58263efa880b732484477594e1 100644

--- a/chrome/browser/devtools/device/adb/mock_adb_server.cc

+++ b/chrome/browser/devtools/device/adb/mock_adb_server.cc

@@ -601,19 +601,16 @@ void MockAndroidConnection::SendHTTPResponse(const std::string& body) {

void StartMockAdbServer(FlushMode flush_mode) {

BrowserThread::PostTaskAndReply(

- BrowserThread::IO,

- FROM_HERE,

+ BrowserThread::IO, FROM_HERE,

base::Bind(&StartMockAdbServerOnIOThread, flush_mode),

- base::MessageLoop::QuitClosure());

+ base::MessageLoop::QuitWhenIdleClosure());

content::RunMessageLoop();

}

void StopMockAdbServer() {

- BrowserThread::PostTaskAndReply(

- BrowserThread::IO,

- FROM_HERE,

- base::Bind(&StopMockAdbServerOnIOThread),

- base::MessageLoop::QuitClosure());

+ BrowserThread::PostTaskAndReply(BrowserThread::IO, FROM_HERE,

+ base::Bind(&StopMockAdbServerOnIOThread),

+ base::MessageLoop::QuitWhenIdleClosure());

content::RunMessageLoop();

}