chrome/browser/chromeos/input_method/textinput_test_helper.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/textinput_test_helper.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc ('k') | chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/textinput_test_helper.cc

diff --git a/chrome/browser/chromeos/input_method/textinput_test_helper.cc b/chrome/browser/chromeos/input_method/textinput_test_helper.cc

index 34554d263a42f6dd18080d536bc36dac92dac452..7a7d3a6753780443dcedd8f848e74d37eced1a2a 100644

--- a/chrome/browser/chromeos/input_method/textinput_test_helper.cc

+++ b/chrome/browser/chromeos/input_method/textinput_test_helper.cc

@@ -76,7 +76,7 @@ void TextInputTestHelper::OnTextInputTypeChanged(

latest_text_input_type_ =

client ? client->GetTextInputType() : ui::TEXT_INPUT_TYPE_NONE;

if (waiting_type_ == WAIT_ON_TEXT_INPUT_TYPE_CHANGED)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void TextInputTestHelper::OnShowImeIfNeeded() {

@@ -89,13 +89,13 @@ void TextInputTestHelper::OnInputMethodDestroyed(

void TextInputTestHelper::OnFocus() {

focus_state_ = true;

if (waiting_type_ == WAIT_ON_FOCUS)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void TextInputTestHelper::OnBlur() {

focus_state_ = false;

if (waiting_type_ == WAIT_ON_BLUR)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void TextInputTestHelper::OnCaretBoundsChanged(

@@ -109,7 +109,7 @@ void TextInputTestHelper::OnCaretBoundsChanged(

return;

}

if (waiting_type_ == WAIT_ON_CARET_BOUNDS_CHANGED)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

void TextInputTestHelper::OnTextInputStateChanged(