chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc ('k') | chrome/browser/browsing_data/browsing_data_helper_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc

index 32a8fc2e15ec37897f61a58de7e5598e8bd11050..7b572617f7008aeceb054f2fbe19ecfc621f7def 100644

--- a/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc

@@ -87,9 +87,7 @@ class BrowsingDataFileSystemHelperTest : public testing::Test {

// Unblocks the current MessageLoop. Should be called in response to some sort

// of async activity in a callback method.

- void Notify() {

- base::MessageLoop::current()->Quit();

- }

+ void Notify() { base::MessageLoop::current()->QuitWhenIdle(); }

// Callback that should be executed in response to

// storage::FileSystemContext::OpenFileSystem.