chrome/browser/autofill/autofill_browsertest.cc - Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_browsertest.cc

Issue 1395103003: Don't use base::MessageLoop::{Quit,QuitClosure} in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autofill/autofill_browsertest.cc

diff --git a/chrome/browser/autofill/autofill_browsertest.cc b/chrome/browser/autofill/autofill_browsertest.cc

index ecd5e80509ff4bef54bf0bfe59e5f1a6536bb71b..a298a6ebb4d699e760da4a8661f25a487c9ade4e 100644

--- a/chrome/browser/autofill/autofill_browsertest.cc

+++ b/chrome/browser/autofill/autofill_browsertest.cc

@@ -97,7 +97,7 @@ class WindowedPersonalDataManagerObserver

// PersonalDataManagerObserver:

void OnPersonalDataChanged() override {

if (has_run_message_loop_) {

- base::MessageLoopForUI::current()->Quit();

+ base::MessageLoopForUI::current()->QuitWhenIdle();

has_run_message_loop_ = false;

}

alerted_ = true;

« no previous file with comments | « chrome/browser/autocomplete/shortcuts_backend_unittest.cc ('k') | chrome/browser/autofill/autofill_uitest_util.cc » ('j') | no next file with comments »