Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1395103002: Increase Web Notification timeout to 20 seconds (Closed)

Created:
5 years, 2 months ago by johnme
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Increase Web Notification timeout to 20 seconds Data from partners suggests this improves re-engagement. We intend to revisit this in m48 with a Finch experiment. BUG=530697 Review URL: https://codereview.chromium.org/1395483002 Cr-Commit-Position: refs/heads/master@{#352904} (cherry picked from commit 07e31a310e07d3aa8a07c45670e70e89094317b7) Committed: https://chromium.googlesource.com/chromium/src/+/b2fa718b0cff37c436964a52c75a78d4fe538b29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/message_center/message_center_style.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/message_center/message_center_style.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/message_center/notification.h View 3 chunks +12 lines, -5 lines 0 comments Download
M ui/message_center/notification.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/message_center/popup_timer.cc View 2 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
johnme
5 years, 2 months ago (2015-10-09 10:37:48 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b2fa718b0cff37c436964a52c75a78d4fe538b29.

Powered by Google App Engine
This is Rietveld 408576698