Issue 13951021: Disable AutofillDialogCocoaBrowserTest.DisplayUI due to modal dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13951021: Disable AutofillDialogCocoaBrowserTest.DisplayUI due to modal dialog. (Closed)

Created:
7 years, 8 months ago by tapted

Modified:
7 years, 8 months ago

Reviewers:
groby-ooo-7-16, sail

CC:
chromium-reviews, sail+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Disable AutofillDialogCocoaBrowserTest.DisplayUI due to modal dialog. Builder output from an asan tree closer: AutofillDialogCocoaBrowserTest.DisplayUI: dyld: warning, unknown environment variable: DYLD_NO_PIE Killed (timed out). I ran an asan build locally, and it popped up a modal dialog "browser_tests would like access to your Contacts". BUG=234008 TBR=sail@chromium.org, groby@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195428

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tapted

TBR + dcommit since this has had a tree-closer red for a few days. I'll ...

7 years, 8 months ago (2013-04-22 01:11:21 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r195428.

Expand Messages | Collapse Messages