Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: runtime/vm/object.cc

Issue 13951019: - Allow for experimentation with different header sizes. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 21320)
+++ runtime/vm/object.cc (working copy)
@@ -593,17 +593,26 @@
intptr_t leftover_size = original_size - used_size;
uword addr = RawObject::ToAddr(obj.raw()) + used_size;
- ASSERT(TypedData::InstanceSize(0) == Object::InstanceSize());
- // Update the leftover space as an TypedDataInt8Array object.
- RawTypedData* raw =
- reinterpret_cast<RawTypedData*>(RawObject::FromAddr(addr));
- uword tags = 0;
- tags = RawObject::SizeTag::update(leftover_size, tags);
- tags = RawObject::ClassIdTag::update(kTypedDataInt8ArrayCid, tags);
- raw->ptr()->tags_ = tags;
- intptr_t leftover_len = (leftover_size - TypedData::InstanceSize(0));
- ASSERT(TypedData::InstanceSize(leftover_len) == leftover_size);
- raw->ptr()->length_ = Smi::New(leftover_len);
+ if (leftover_size >= TypedData::InstanceSize(0)) {
+ // Update the leftover space as an TypedDataInt8Array object.
+ RawTypedData* raw =
+ reinterpret_cast<RawTypedData*>(RawObject::FromAddr(addr));
+ uword tags = 0;
+ tags = RawObject::SizeTag::update(leftover_size, tags);
+ tags = RawObject::ClassIdTag::update(kTypedDataInt8ArrayCid, tags);
+ raw->ptr()->tags_ = tags;
+ intptr_t leftover_len = (leftover_size - TypedData::InstanceSize(0));
+ ASSERT(TypedData::InstanceSize(leftover_len) == leftover_size);
+ raw->ptr()->length_ = Smi::New(leftover_len);
+ } else {
+ // Update the leftover space as a basic object.
+ ASSERT(leftover_size == Object::InstanceSize());
+ RawObject* raw = reinterpret_cast<RawObject*>(RawObject::FromAddr(addr));
+ uword tags = 0;
+ tags = RawObject::SizeTag::update(leftover_size, tags);
+ tags = RawObject::ClassIdTag::update(kInstanceCid, tags);
+ raw->ptr()->tags_ = tags;
+ }
}
}
« no previous file with comments | « runtime/vm/object.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698