Issue 13951014: [NaCl SDK] nacl_io: opening a node immediately after mounting would fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13951014: [NaCl SDK] nacl_io: opening a node immediately after mounting would fail. (Closed)

Created:
7 years, 8 months ago by binji

Modified:
7 years, 8 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] nacl_io: opening a node immediately after mounting would fail. Most nacl_io calls are made off-main-thread, but mount() is not necessarily. Mounting an html5fs mount requires an asynchronous call to PPAPI; until that callback returned, all further calls to that mount would fail. The fix here does the following: * If the mount() call is made on the main thread, make an asynchronous call to open the filesystem, but block all further calls until the filesystem is open. * If the mount() call is made off-main-thread, the filesystem open call blocks until it is finished. BUG=230410 R=noelallen@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194396

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -39 lines)			Patch
M	native_client_sdk/src/libraries/nacl_io/mount_html5fs.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io/mount_html5fs.cc	View	1	6 chunks	+35 lines, -14 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io/pepper_interface.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io/real_pepper_interface.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io/real_pepper_interface.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io_test/mount_html5fs_test.cc	View	1 2	14 chunks	+158 lines, -23 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_io_test/pepper_interface_mock.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

binji

7 years, 8 months ago (2013-04-16 18:20:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r194396 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13951014: [NaCl SDK] nacl_io: opening a node immediately after mounting would fail. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fix windows #

Messages