ui/message_center/message_center_style.cc - Issue 1395093002: Fix system notifications incorrectly marked as type WEB_PAGE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/message_center_style.cc

Issue 1395093002: Fix system notifications incorrectly marked as type WEB_PAGE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timeout

Patch Set: Addressed Peter's review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/status_icons/desktop_notification_balloon.cc ('K') | « ui/message_center/message_center_style.h ('k') | ui/message_center/notification.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/message_center/message_center_style.cc

diff --git a/ui/message_center/message_center_style.cc b/ui/message_center/message_center_style.cc

index 33f875796c5f0c75485cb681f525d03a7b8fb115..50172f3d1123e17d0c12ee64f78281eeb5c2203d 100644

--- a/ui/message_center/message_center_style.cc

+++ b/ui/message_center/message_center_style.cc

@@ -57,7 +57,7 @@ const int kAutocloseHighPriorityDelaySeconds = 25;

// Web notifications use a larger timeout for now, which improves re-engagement.

// TODO(johnme): Use Finch to experiment with different values for this, then

// consider replacing kAutocloseDefaultDelaySeconds with this.

Peter Beverloo 2015/10/09 12:55:23 nit: Please refer to a bug.

johnme 2015/10/09 14:20:41 Done.

-const int kAutocloseWebNotificationDelaySeconds = 20;

+const int kAutocloseWebPageDelaySeconds = 20;

// Colors.

const SkColor kBackgroundLightColor = SkColorSetRGB(0xf1, 0xf1, 0xf1);

« chrome/browser/status_icons/desktop_notification_balloon.cc ('K') | « ui/message_center/message_center_style.h ('k') | ui/message_center/notification.h » ('j') | no next file with comments »