chrome/browser/notifications/notification.cc - Issue 1395093002: Fix system notifications incorrectly marked as type WEB_PAGE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification.cc

Issue 1395093002: Fix system notifications incorrectly marked as type WEB_PAGE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timeout

Patch Set: Addressed Peter's review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/background/background_contents_service.cc ('K') | « chrome/browser/notifications/notification.h ('k') | chrome/browser/notifications/platform_notification_service_impl.cc » ('j') | chrome/browser/status_icons/desktop_notification_balloon.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification.cc

diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc

index 076e780c2e67a40fef3a0e49c601901b5dc5d1c3..1bd24964b3a866b642b6a3a134b9fb8eeb0c1fe1 100644

--- a/chrome/browser/notifications/notification.cc

+++ b/chrome/browser/notifications/notification.cc

@@ -4,26 +4,6 @@

#include "chrome/browser/notifications/notification.h"

-Notification::Notification(const GURL& origin_url,

- const base::string16& title,

- const base::string16& body,

- const gfx::Image& icon,

- const base::string16& display_source,

- const std::string& tag,

- NotificationDelegate* delegate)

- : message_center::Notification(message_center::NOTIFICATION_TYPE_SIMPLE,

- delegate->id(),

- title,

- body,

- icon,

- display_source,

- origin_url,

- message_center::NotifierId(origin_url),

- message_center::RichNotificationData(),

- delegate),

- tag_(tag),

- delegate_(delegate) {}

Notification::Notification(

message_center::NotificationType type,

const base::string16& title,