chrome/browser/local_discovery/privet_notifications.cc - Issue 1395093002: Fix system notifications incorrectly marked as type WEB_PAGE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/privet_notifications.cc

Issue 1395093002: Fix system notifications incorrectly marked as type WEB_PAGE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@timeout

Patch Set: Addressed Peter's review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/background/background_contents_service.cc ('K') | « chrome/browser/chromeos/power/peripheral_battery_observer.cc ('k') | chrome/browser/notifications/message_center_notifications_browsertest.cc » ('j') | chrome/browser/status_icons/desktop_notification_balloon.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/privet_notifications.cc

diff --git a/chrome/browser/local_discovery/privet_notifications.cc b/chrome/browser/local_discovery/privet_notifications.cc

index 9c529a9800acb186c873d7f395bcaa5d69c14abb..ddecc245002ec73e6d409a39fca6ddc066660443 100644

--- a/chrome/browser/local_discovery/privet_notifications.cc

+++ b/chrome/browser/local_discovery/privet_notifications.cc

@@ -261,7 +261,8 @@ void PrivetNotificationService::PrivetNotify(int devices_active,

message_center::NOTIFICATION_TYPE_SIMPLE, title, body,

ui::ResourceBundle::GetSharedInstance().GetImageNamed(

IDR_LOCAL_DISCOVERY_CLOUDPRINT_ICON),

- message_center::NotifierId(GURL(kPrivetNotificationOriginUrl)),

+ message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,

+ kPrivetNotificationID),

product_name, GURL(kPrivetNotificationOriginUrl), kPrivetNotificationID,

rich_notification_data, new PrivetNotificationDelegate(profile_));