Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: pkg/analyzer/test/src/context/context_test.dart

Issue 1395033003: Ignore absence of DOCTYPE in HTML files. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/html.dart ('k') | pkg/analyzer/test/src/task/html_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.src.context.context_test; 5 library test.src.context.context_test;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analyzer/file_system/memory_file_system.dart'; 9 import 'package:analyzer/file_system/memory_file_system.dart';
10 import 'package:analyzer/src/cancelable_future.dart'; 10 import 'package:analyzer/src/cancelable_future.dart';
(...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after
898 "/test.html", 898 "/test.html",
899 r''' 899 r'''
900 <html><head> 900 <html><head>
901 <script type='application/dart' src='test.dart'/> 901 <script type='application/dart' src='test.dart'/>
902 </head></html>'''); 902 </head></html>''');
903 AnalysisErrorInfo errorInfo = context.getErrors(source); 903 AnalysisErrorInfo errorInfo = context.getErrors(source);
904 expect(errorInfo, isNotNull); 904 expect(errorInfo, isNotNull);
905 List<AnalysisError> errors = errorInfo.errors; 905 List<AnalysisError> errors = errorInfo.errors;
906 expect(errors, hasLength(0)); 906 expect(errors, hasLength(0));
907 errors = context.computeErrors(source); 907 errors = context.computeErrors(source);
908 expect(errors, hasLength(3)); 908 expect(errors, hasLength(2));
909 } 909 }
910 910
911 void test_getHtmlFilesReferencing_html() { 911 void test_getHtmlFilesReferencing_html() {
912 Source htmlSource = addSource( 912 Source htmlSource = addSource(
913 "/test.html", 913 "/test.html",
914 r''' 914 r'''
915 <html><head> 915 <html><head>
916 <script type='application/dart' src='test.dart'/> 916 <script type='application/dart' src='test.dart'/>
917 <script type='application/dart' src='test.js'/> 917 <script type='application/dart' src='test.js'/>
918 </head></html>'''); 918 </head></html>''');
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1711 void test_performAnalysisTask_importedLibraryAdd_html() { 1711 void test_performAnalysisTask_importedLibraryAdd_html() {
1712 Source htmlSource = addSource( 1712 Source htmlSource = addSource(
1713 "/page.html", 1713 "/page.html",
1714 r''' 1714 r'''
1715 <html><body><script type="application/dart"> 1715 <html><body><script type="application/dart">
1716 import '/libB.dart'; 1716 import '/libB.dart';
1717 main() {print('hello dart');} 1717 main() {print('hello dart');}
1718 </script></body></html>'''); 1718 </script></body></html>''');
1719 _analyzeAll_assertFinished(); 1719 _analyzeAll_assertFinished();
1720 context.computeErrors(htmlSource); 1720 context.computeErrors(htmlSource);
1721 expect(_hasAnalysisErrorWithErrorSeverity(context.getErrors(htmlSource)), 1721 // expect(_hasAnalysisErrorWithErrorSeverity(context.getErrors(htmlSource)),
1722 isTrue, 1722 // isTrue,
1723 reason: "htmlSource has an error"); 1723 // reason: "htmlSource has an error");
1724 // add libB.dart and analyze 1724 // add libB.dart and analyze
1725 Source libBSource = addSource("/libB.dart", "library libB;"); 1725 Source libBSource = addSource("/libB.dart", "library libB;");
1726 _analyzeAll_assertFinished(); 1726 _analyzeAll_assertFinished();
1727 expect( 1727 expect(
1728 context.getResolvedCompilationUnit2(libBSource, libBSource), isNotNull, 1728 context.getResolvedCompilationUnit2(libBSource, libBSource), isNotNull,
1729 reason: "libB resolved 2"); 1729 reason: "libB resolved 2");
1730 // TODO (danrubel) commented out to fix red bots 1730 // TODO (danrubel) commented out to fix red bots
1731 // context.computeErrors(htmlSource); 1731 // context.computeErrors(htmlSource);
1732 // AnalysisErrorInfo errors = _context.getErrors(htmlSource); 1732 // AnalysisErrorInfo errors = _context.getErrors(htmlSource);
1733 // expect( 1733 // expect(
(...skipping 781 matching lines...) Expand 10 before | Expand all | Expand 10 after
2515 } 2515 }
2516 } 2516 }
2517 2517
2518 class _AnalysisContextImplTest_test_applyChanges_removeContainer 2518 class _AnalysisContextImplTest_test_applyChanges_removeContainer
2519 implements SourceContainer { 2519 implements SourceContainer {
2520 Source libB; 2520 Source libB;
2521 _AnalysisContextImplTest_test_applyChanges_removeContainer(this.libB); 2521 _AnalysisContextImplTest_test_applyChanges_removeContainer(this.libB);
2522 @override 2522 @override
2523 bool contains(Source source) => source == libB; 2523 bool contains(Source source) => source == libB;
2524 } 2524 }
OLDNEW
« no previous file with comments | « pkg/analyzer/lib/src/task/html.dart ('k') | pkg/analyzer/test/src/task/html_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698