Issue 13950014: Revert "Switch RegularExpression from YARR to V8"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13950014: Revert "Switch RegularExpression from YARR to V8" (Closed)

Created:
7 years, 8 months ago by caseq1

Modified:
7 years, 8 months ago

Reviewers:
esprehn, yurys, adamk, abarth-chromium

CC:
blink-reviews, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Switch RegularExpression from YARR to V8" This caused following inspector tests to crash, assert or time out: inspector-protocol/debugger-step-into-dedicated-worker.html inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html http/tests/inspector/search/search-in-resources.html TBR=esprehn,yurys@chromium.org,abarth,adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148904

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -94 lines)			Patch
D	LayoutTests/fast/forms/pattern-attribute-invalid-regex.html	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	LayoutTests/fast/forms/pattern-attribute-invalid-regex-expected.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/html/BaseTextInputType.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/core/platform/text/RegularExpression.h	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	Source/core/platform/text/RegularExpression.cpp	View	2 chunks	+41 lines, -58 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

caseq1

7 years, 8 months ago (2013-04-23 10:40:14 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r148904 (presubmit successful).

Expand Messages | Collapse Messages