Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 13950014: Revert "Switch RegularExpression from YARR to V8" (Closed)

Created:
7 years, 8 months ago by caseq1
Modified:
7 years, 8 months ago
CC:
blink-reviews, jeez
Visibility:
Public.

Description

Revert "Switch RegularExpression from YARR to V8" This caused following inspector tests to crash, assert or time out: inspector-protocol/debugger-step-into-dedicated-worker.html inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html http/tests/inspector/search/search-in-resources.html TBR=esprehn,yurys@chromium.org,abarth,adamk BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -94 lines) Patch
D LayoutTests/fast/forms/pattern-attribute-invalid-regex.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/forms/pattern-attribute-invalid-regex-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/html/BaseTextInputType.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/platform/text/RegularExpression.h View 3 chunks +8 lines, -6 lines 0 comments Download
M Source/core/platform/text/RegularExpression.cpp View 2 chunks +41 lines, -58 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
caseq1
7 years, 8 months ago (2013-04-23 10:40:14 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r148904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698