Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1394993006: Merge to XFA: Pass IJS_Runtime, not IJS_Context, to native object constructors. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Pass IJS_Runtime, not IJS_Context, to native object constructors. Original Review URL: https://codereview.chromium.org/1389163007 . (cherry picked from commit 848a13b6777cbff8cc4aea3ab3d69eaa0b82ae6c) Merge conflics in: fpdfsdk/src/javascript/JS_Runtime.cpp fpdfsdk/src/javascript/JS_Runtime_Stub.cpp fpdfsdk/src/jsapi/fxjs_v8.cpp R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3342090d65e852f3f37a8f04d3fbe3ff2467d05c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -183 lines) Patch
M fpdfsdk/include/javascript/IJavaScript.h View 3 chunks +6 lines, -1 line 0 comments Download
M fpdfsdk/include/jsapi/fxjs_v8.h View 4 chunks +7 lines, -9 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 6 chunks +12 lines, -73 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 5 chunks +4 lines, -6 lines 0 comments Download
M fpdfsdk/src/javascript/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 7 chunks +11 lines, -17 lines 0 comments Download
M fpdfsdk/src/javascript/Field.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 3 chunks +6 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 3 chunks +7 lines, -11 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 1 chunk +3 lines, -0 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 3 chunks +14 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime_Stub.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 4 chunks +4 lines, -7 lines 0 comments Download
M fpdfsdk/src/javascript/global.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 chunk +6 lines, -11 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 6 chunks +10 lines, -13 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
Lei, for review.
5 years, 2 months ago (2015-10-13 16:49:10 UTC) #1
Lei Zhang
lgtm
5 years, 2 months ago (2015-10-13 21:20:15 UTC) #2
Tom Sepez
5 years, 2 months ago (2015-10-13 22:00:15 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3342090d65e852f3f37a8f04d3fbe3ff2467d05c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698